-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart][dart-dio] Add built_value date support w/o timemachine #9180
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) |
While testing the generator and thereby this PR, I noticed two problems. The first one is directly related to the extension. The second one might be a separate issue for which I can open a new issue.
Which leads to the following errors.
|
Do you have an example spec or repro? Please create a new issue for 2. and CC me. |
The problem occurs in this basic example. With
|
I see, an array of dates. |
|
Shippable failure is unrelated. |
Now works as intended. |
Looking for reviews |
All tests passed after restart. |
Fixes #9095
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x