Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Avoid DeprecationWarning in inspect.getargspec on Python 3 #9271

Merged
merged 2 commits into from
Apr 30, 2021
Merged

[Python] Avoid DeprecationWarning in inspect.getargspec on Python 3 #9271

merged 2 commits into from
Apr 30, 2021

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Apr 15, 2021

Closes #9270

The change is in modules/openapi-generator/src/main/resources/python-legacy/model.mustache.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@johnthagen
Copy link
Contributor Author

Mentioning Python technical committee as recommended: @spacether @arun-nalla @Jyhess @tomplus @kenjones-cisco @cbornet @mbohlool @frol @taxpon

@johnthagen johnthagen changed the title Avoid DeprecationWarning in inspect.getargspec on Python 3 [Python] Avoid DeprecationWarning in inspect.getargspec on Python 3 Apr 15, 2021
Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; thank you for your PR!

@spacether spacether added this to the 5.1.1 milestone Apr 30, 2021
@spacether spacether merged commit a88313c into OpenAPITools:master Apr 30, 2021
@johnthagen johnthagen deleted the patch-1 branch April 30, 2021 19:14
jaredsmith added a commit to muxinc/mux-python that referenced this pull request Jan 12, 2023
In order to get the tests to run successfully, I also updated the
mustache template in gen/templates/mode.mustache to fix a deprecated
usage of the `inspect.getargspec` call, based on this PR:
OpenAPITools/openapi-generator#9271

Signed-off-by: Jared Smith <jsmith@mux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants