Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE4 - Support FGuid with in/out Helpers #9291

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

jwittner
Copy link
Contributor

@jwittner jwittner commented Apr 19, 2021

If the API we're generating for uses UUID, which is appropriately mapped to FGuid for UE4, we get compiler errors because the default templated c++ methods get called with FGuid, which doesn't support those standard operations.

Here I've added FGuid specializations akin to how FDateTime is handled, which resolves the compiler errors and adds FGuid support.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Kahncode

@Kahncode
Copy link
Contributor

Looks good, thanks!

@wing328 wing328 added this to the 5.1.1 milestone Apr 20, 2021
@wing328 wing328 merged commit 28e0d9b into OpenAPITools:master Apr 20, 2021
@wing328
Copy link
Member

wing328 commented Apr 20, 2021

PR merged. Updated samples via 41f586b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants