Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS][Flow] Better code format, update samples #9438

Merged
merged 1 commit into from
May 10, 2021
Merged

[JS][Flow] Better code format, update samples #9438

merged 1 commit into from
May 10, 2021

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 10, 2021

  • Better code format, update samples

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@wing328 wing328 changed the title better code format, update samples [JS][Flow] Better code format, update samples May 10, 2021
@wing328 wing328 added this to the 5.2.0 milestone May 10, 2021
@wing328
Copy link
Member Author

wing328 commented May 10, 2021

drone.ci failure not related to this PR.

@wing328 wing328 marked this pull request as ready for review May 10, 2021 10:26
@wing328 wing328 merged commit 4bb5c8a into master May 10, 2021
@wing328 wing328 deleted the js-flow-code branch May 10, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant