Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes python test_fake_api tests #9483

Merged
merged 11 commits into from
May 18, 2021
Merged

Fixes python test_fake_api tests #9483

merged 11 commits into from
May 18, 2021

Conversation

spacether
Copy link
Contributor

Fixes test_fake_pi tests
This issue: #9482
revealed that these tests were not working right.
This PR will fix them.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether linked an issue May 14, 2021 that may be closed by this pull request
[BUG] Python client API test not functional #9482
Closed
6 tasks
@spacether spacether marked this pull request as draft May 14, 2021 17:01
@spacether spacether changed the title Fixes test_fake_pi tests Fixes python test_fake_api tests May 17, 2021
@spacether spacether marked this pull request as ready for review May 18, 2021 02:10
@spacether
Copy link
Contributor Author

CircleCi errors are unrelated to this PR

@spacether spacether added this to the 5.2.0 milestone May 18, 2021
@spacether spacether merged commit fb3aed6 into OpenAPITools:master May 18, 2021
@spacether spacether deleted the fix_python_test_fake_api branch May 18, 2021 03:16
premiumitsolution pushed a commit to premiumitsolution/openapi-generator that referenced this pull request May 26, 2021
@spacether @Fornori
Fixes python test_fake_api tests (OpenAPITools#9483)
15aa43e 
* Fixes test_upload_download_file

* Fixes test_string

* Fixes test_string_enum

* Fixes test_number_with_validations test_composed_one_of_number_with_validations

* Fixes two more tests

* Fixes test_array_of_enums

* Fixes two tests

* Removes comment

* Fixes serializationf of composed schema object models, fixes test

* Samples regenerated

* Removes pdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Python
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

[BUG] Python client API test not functional
1 participant
@spacether