Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5][client] fix binary response #9595

Merged
merged 2 commits into from
May 27, 2021

Conversation

4brunu
Copy link
Contributor

@4brunu 4brunu commented May 26, 2021

This PR fixes the download of binary response and is related to #9308

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@aymanbagabas
Copy link
Contributor

I hope this would be the default behavior in 5.2.x cause if not, #9583 would break since it doesn't handle file/binary <-> URL relations.

@wing328 wing328 added this to the 5.2.0 milestone May 27, 2021
@wing328 wing328 merged commit a61db6e into OpenAPITools:master May 27, 2021
@4brunu
Copy link
Contributor Author

4brunu commented May 27, 2021

@aymanbagabas I left some comments on #9308 (comment) related to this

@4brunu 4brunu deleted the feature/fix-binary-response branch June 1, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants