-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add audio narration (updated) #346
Conversation
…udio_narration # Conflicts: # requirements.txt
@0dm can you please comment about what would be required to get an analogous implementation of this for Mac? 🙏 |
audio_frames.append(indata.copy()) | ||
|
||
# open InputStream and start recording while ActionEvents are recorded | ||
audio_stream = sounddevice.InputStream( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angelala3252 @0dm what is the easiest way to implement a MacOS-compatible analog of this? Can we re-use existing code in other PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#362 has a good method of getting audio devices via Apple AVFoundation, I'm sure it can be used here with minimal issue. I'm not sure if it'll be plug & play with my PR though, would need some changes depending on the implementation.
The issue with not being able to capture audio with openadapt.record running should be fixed after the changes in _macos a while ago. |
openadapt/record.py
Outdated
@@ -24,6 +24,11 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update module documentation with optional flag example
@angelala3252 can you please fix merge commits? I believe you will need to re-generate the alembic scripts as well. Please also confirm this works with poetry. After checking out your branch and running
|
requirements.txt
Outdated
git+https://github.com/openai/whisper.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still the recommended way to install whisper?
I also found https://pypi.org/project/openai-whisper/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry add openai-whisper
isn't working for me as I get issues building wheel for llvmlite and numba, and also Unable to find installation candidates for triton (2.0.0)
. The fixes online all suggest that this is because pip is older than version 19.0, but our pip is version 23.1.2. poetry add git+https://github.com/openai/whisper.git
works so for now I'm just going with that.
After pulling from main, for some reason importing sounddevice breaks recordings. I can record audio just fine, but nothing else can be recorded and no window events can be registered and the recording hangs indefinitely after Ctrl+C. This even happens when I'm not recording audio and I can't figure out why. I'm using the same version (0.4.6) I was when everything still worked. |
@angelala3252 this may be due to @0dm any ideas? 🙏 |
Implemented in #673 @angelala3252 thank you for blazing the trail here!! 🙏 |
Summary
Updated version of PR #195 due to deleting previous fork. This feature is blocked until MacOS accessibility issues are fixed.
(Addresses #164)
Checklist