fix: use RAII to release resources in async task #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanghenshui
changed the title
AlexStocks
changed the title
|
如果 arg 是 new 出来的，这么改动，能保证 arg 会被释放掉么？ |
|
可以的， unique_ptr接受一个指针， 在析构的时候调用对应参数类型的delete函数 |
AlexStocks
approved these changes
May 15, 2023
luky116
approved these changes
May 15, 2023
loveyacper
reviewed
May 16, 2023
loveyacper
reviewed
May 16, 2023
|
传递 |
loveyacper
approved these changes
May 16, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
…1502) * use raii to release resources in async task * use static_cast instead of reinterpret_cast --------- Co-authored-by: J1senn <J1senn@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.