Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codis2pika to pika #1510 #1514

Merged
merged 4 commits into from
May 20, 2023

Conversation

chenbt-hz
Copy link
Collaborator

Add codis2pika to pika
fix #1510

/* Parse the master entry */
count := nextInteger(&inx, elements) // count
deleted := nextInteger(&inx, elements) // deleted
numFields := int(nextInteger(&inx, elements)) // num-fields

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
args = append(args, fields[j], nextString(&inx, elements))
}
} else { // get field by lp.Next()
num := int(nextInteger(&inx, elements))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of a 64-bit integer from [strconv.ParseInt](1) to a lower bit size type int without an upper bound check.
//原Timeout为3s,为降低broken pipe概率调整为8s
dialer.Timeout = 8 * time.Second
if isTls {
conn, err = tls.DialWithDialer(&dialer, "tcp", address, &tls.Config{InsecureSkipVerify: true})

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@chenbt-hz chenbt-hz marked this pull request as draft May 18, 2023 00:47
@chenbt-hz chenbt-hz marked this pull request as ready for review May 18, 2023 01:26
@AlexStocks AlexStocks merged commit 6cd4cf4 into OpenAtomFoundation:unstable May 20, 2023
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
* add codis2pika to pika;update go path

* update pika.yml
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
* add codis2pika to pika;update go path

* update pika.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codis2pika to pika
3 participants