Added tcl tests for string #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -22,6 +22,7 @@ set ::all_tests { | |||
| unit/type/list-3 | |||
| unit/type/set | |||
| unit/type/zset | |||
| unit/type/string | |||
| # unit/type/hash | |||
| # unit/sort | |||
| # unit/expire | |||
There was a problem hiding this comment.
Without the actual code patch, it's challenging to provide a thorough code review. However, based on the information you provided, here are some general suggestions:
- Check for any syntax errors after adding the new line.
- Verify if the new unit test case for
unit/type/stringis correctly implemented, including proper assertions and expected outcomes. - Uncomment or remove the commented out lines related to other unit tests (
unit/type/hash,unit/sort,unit/expire) if they are not necessary in this code patch. - Conduct thorough testing to ensure that the existing functionality of the code is not affected by the changes.
For a more detailed code review, please include the actual code patch or specific sections that require attention.
|
请将无法通过的 case 添加至 #1605 的待修复列表中，以便后续跟进修复。 |
machinly
approved these changes
Jul 3, 2023
好的 |
AlexStocks
approved these changes
Jul 3, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1605