Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to include TimeSeriesCrossValidation and pyth… #10

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

danielorf
Copy link
Contributor

…on-Levenshtein

@danielorf
Copy link
Contributor Author

This also includes the additional requirements pulled in by requirements.txt install for full snapshot

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

Why are there so many new libraries added? Does this picks up all libraries and dependencies?

If so, how did you do it?

@danielorf
Copy link
Contributor Author

danielorf commented Feb 25, 2021

I installed everything already in requirements.txt, installed TimeSeriesCrossValidation + python-Levenshtein and then ran pip freeze > requirements.txt again.

It's kinda overkill, but I usually either go for a very light of requirements with flexible operators (e.g. ">=" vs "==") or take a full snapshot of every dependency. With the latter you get a complete picture of deps up front which can be good for security scans.

@DidierRLopes
Copy link
Collaborator

Amazing, thank you!

I was curious because I used pipreqs library, and it didn't work as smoothly as I was expecting.

@DidierRLopes DidierRLopes merged commit bb61a70 into OpenBB-finance:main Feb 25, 2021
DidierRLopes pushed a commit that referenced this pull request Apr 19, 2021
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 1, 2023
piiq pushed a commit that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants