Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pinned lightgbm conda version #4164

Closed
wants to merge 1 commit into from
Closed

Update pinned lightgbm conda version #4164

wants to merge 1 commit into from

Conversation

martinb-ai
Copy link
Contributor

Poetry had troubles updating lightgbm

image

Now, on a fresh env the following should work:

conda env create -n pr --file build/conda/conda-3-9-env-full.yaml
poetry install -E all

@martinb-ai martinb-ai added the bug Fix bug label Feb 7, 2023
@martinb-ai martinb-ai self-assigned this Feb 7, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 7, 2023
@martinb-ai
Copy link
Contributor Author

@jmaslek Can you quickly test new env with this and let me know if it runs for you? Thanks

@jmaslek
Copy link
Collaborator

jmaslek commented Feb 7, 2023

Can you push this dep fix to the poetry PR instead of just a standalone hotfix:

#4076

@piiq
Copy link
Contributor

piiq commented Feb 8, 2023

I'll be handling this in #4166 , thanks @martinb-bb

@piiq piiq closed this Feb 8, 2023
@piiq piiq deleted the hotfix/lightgbm-conda branch February 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees

@martinb-ai martinb-ai

Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinb-ai @jmaslek @piiq