Update reddit connection client #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiq
added
bug
![reviewpad[bot]](https://avatars.githubusercontent.com/in/196990?s=60&v=4){kind=small}
jmaslek
approved these changes
Mar 14, 2023
jmaslek
added a commit
that referenced
this pull request
Apr 13, 2023
* Change deprecated psaw dependency to the maintained pmaw * Fix docstring linting errors * Remove deprecated watchlist command because it's taking too long to run * Remove deprecated spac command because it's taking too long to run * Update SDK and trailmap * Fix legacy seaborn chart popping up when calling redditsent * Clean up spacc code * Refactor reddit ba commands to reflect the dependency change * Change regex that searches for tickers * Fix popular command error when no stock tickers found * Update tests * Update requirements.txt files * Sync dependencies with upstream --------- Co-authored-by: James Maslek <jmaslek11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to change the
psawreddit client that's not maintained to thepmawreddit client that the initial library maintainer points to as the currently maintained one.While doing this I have:
watchlist,spac). These commands were unavailable in the help menu but still were accessible via direct command input. Now they're gone-gonepopular, and a modified version ofgetdd. Withpmawthese commands still take some time to run, but it is not as painfully as it was.