Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub | save preferences locally #4494

Merged
merged 34 commits into from
Mar 16, 2023
Merged

Hub | save preferences locally #4494

merged 34 commits into from
Mar 16, 2023

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Mar 15, 2023

Description

  • Always save preferences locally
  • Remove token from keys
  • Refactor preferences/credentials handlers
  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@montezdesousa montezdesousa added the account Authentication features label Mar 15, 2023
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Mar 15, 2023
@montezdesousa montezdesousa marked this pull request as ready for review March 16, 2023 10:01
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this.

@montezdesousa montezdesousa added the do not merge Label to prevent pull request merge label Mar 16, 2023
@montezdesousa montezdesousa removed the do not merge Label to prevent pull request merge label Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@6e9fefc). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d2b3305 differs from pull request most recent head 3166df8. Consider uploading reports for the commit 3166df8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4494   +/-   ##
==========================================
  Coverage           ?   54.81%           
==========================================
  Files              ?      590           
  Lines              ?    53132           
  Branches           ?        0           
==========================================
  Hits               ?    29126           
  Misses             ?    24006           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@montezdesousa montezdesousa added this pull request to the merge queue Mar 16, 2023
Merged via the queue into develop with commit 18b82a7 Mar 16, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* remove preferences sync

* refactor preferences handler

* change func name

* remove credentials handler + add writedotenv

* remove flair and sync from cloud

* read flair from env dict

* remove unused func

* simplify func

* ruff

* mypy

* remove token from keys

* simplify handle credential

* save exception load env just in case

* uncomment dev link

* pylint

* fix accounte controller

* fix sdk keys bug

* fix bug on apply_configs

* fix feature flags controller tests

* mock properly

* remove comment

* fix more tests

* fix test

* fix screeninfo

* update ff controller after develop merge

* fix sync test
@piiq piiq deleted the feature/hub_sync branch April 24, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Authentication features feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants