Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the activity function's return type? #8

Closed
abargnesi opened this issue Mar 30, 2016 · 3 comments
Closed

What is the activity function's return type? #8

abargnesi opened this issue Mar 30, 2016 · 3 comments

Comments

@abargnesi
Copy link
Member

BEL 1.0 declared abundance as the return type for specific activity types (e.g. kinaseActivity). This implies that the following is semantically valid:

complex( kin( p(HGNC:JAK2) ) )

Given the following function signatures of kinaseActivity and complexAbundance:

kinaseActivity(F:proteinAbundance)abundance
complexAbundance(F:abundance...)abundance

Does this hold true for BEL 2.0's general-purpose activity function?

@ncatlett

@ncatlett
Copy link
Member

complex( kin( p(HGNC:JAK2) ) ) should NOT be semantically valid. Maybe this is a mistake in the BEL 1.0 implementation?

@abargnesi
Copy link
Member Author

Yeah it looks that way. Here was my experience running this through the BelCheck tool.

Thanks for the clarification. We will make sure to correct the semantics in BEL 1.0 & 2.0 implemented in OpenBEL/parsers.

We may want to consider a patch to OpenBEL Framework.

@abargnesi
Copy link
Member Author

Added OpenBEL/openbel-framework#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants