Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements to DX: jest running on src files; tweaks to GH actions #364

Merged
merged 2 commits into from
Dec 10, 2023
Merged

minor improvements to DX: jest running on src files; tweaks to GH actions #364

merged 2 commits into from
Dec 10, 2023

Conversation

enapupe
Copy link
Contributor

@enapupe enapupe commented Nov 14, 2023

  • this PR changes jest to run on source files so building is no longer a necessary step, it also enables TDD (with --watch flag).
  • unify GH actions into a single file that only runs the docker push segment when the build is a tag release; the goal is to have manual deployments when needed and not when development is merged.

Hopefully I'm not breaking prod this time.

vnugent
vnugent reviewed Nov 17, 2023
View reviewed changes
.github/workflows/nodejs.yml Outdated
file: ./Dockerfile
builder: ${{ steps.buildx.outputs.name }}
push: true
tags: vnguyen/openbeta-graph-api:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Git tag instead of latest? Example: vnguyen/openbeta-graph-api:v1.0.2

@enapupe enapupe force-pushed the enapupe/jest-on-src-and-more-dx-improvements branch from c7d15ff to 1f27453 Compare November 17, 2023 15:09
@enapupe enapupe marked this pull request as ready for review November 30, 2023 22:06
@enapupe
Copy link
Contributor Author

enapupe commented Nov 30, 2023

I believe this is missing just that curl command related to ArgoCD.

@enapupe enapupe force-pushed the enapupe/jest-on-src-and-more-dx-improvements branch 3 times, most recently from 6b04f25 to 57a36f2 Compare December 9, 2023 16:58
@enapupe enapupe force-pushed the enapupe/jest-on-src-and-more-dx-improvements branch from 57a36f2 to 5c92faa Compare December 9, 2023 17:08
@vnugent vnugent merged commit e43370c into develop Dec 10, 2023
4 checks passed
@vnugent vnugent mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnugent vnugent vnugent left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enapupe @vnugent