Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCPIP keepalive options #1018

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Add TCPIP keepalive options #1018

merged 1 commit into from
Jan 8, 2024

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented Jan 7, 2024

closes #288

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b67066d) 75.28% compared to head (834601c) 75.29%.

Files Patch % Lines
openc3/lib/openc3/streams/tcpip_socket_stream.rb 9.09% 10 Missing ⚠️
...c3/lib/openc3/interfaces/tcpip_server_interface.rb 0.00% 2 Missing ⚠️
...c3/lib/openc3/interfaces/tcpip_client_interface.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   75.28%   75.29%           
=======================================
  Files         588      588           
  Lines       42990    43005   +15     
  Branches      749      749           
=======================================
+ Hits        32367    32379   +12     
- Misses      10545    10548    +3     
  Partials       78       78           
Flag Coverage Δ
frontend 55.18% <ø> (+0.05%) ⬆️
python 83.65% <ø> (+0.05%) ⬆️
ruby-api 48.69% <ø> (ø)
ruby-backend 80.38% <13.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryanmelt ryanmelt merged commit 96749f9 into main Jan 8, 2024
24 checks passed
@ryanmelt ryanmelt deleted the tcp_keepalive branch January 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP Keep Alive Option
2 participants