Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ace and fix VWidget #348

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Bump ace and fix VWidget #348

merged 1 commit into from
Dec 25, 2022

Conversation

jmthomas
Copy link
Member

No description provided.

value &&
value['json_class'] === 'String' &&
value['raw'] !== undefined
) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a critical bug fix that prevents and values from being displayed in TlmViewer screens. Introduced in my last binary display PR.

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 74.98% // Head: 77.26% // Increases project coverage by +2.28% 🎉

Coverage data is based on head (3e74848) compared to base (7db3abf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   74.98%   77.26%   +2.28%     
==========================================
  Files         446      427      -19     
  Lines       27187    25967    -1220     
  Branches      578      578              
==========================================
- Hits        20385    20063     -322     
+ Misses       6709     5813     -896     
+ Partials       93       91       -2     
Flag Coverage Δ
frontend 75.73% <100.00%> (-0.08%) ⬇️
ruby-api 63.61% <ø> (+13.18%) ⬆️
ruby-backend 79.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlmviewer/src/tools/TlmViewer/EditScreenDialog.vue 66.66% <100.00%> (-13.07%) ⬇️
openc3/lib/openc3/utilities/metric.rb 90.19% <0.00%> (-5.89%) ⬇️
...ool-tlmviewer/src/tools/TlmViewer/Openc3Screen.vue 78.57% <0.00%> (-1.95%) ⬇️
...blemanager/src/tools/TableManager/TableManager.vue 72.77% <0.00%> (-1.05%) ⬇️
openc3/lib/openc3/models/cvt_model.rb 100.00% <0.00%> (ø)
...r-api/app/controllers/running_script_controller.rb
...smos-script-runner-api/config/initializers/cors.rb
...enc3-cosmos-script-runner-api/app/models/script.rb
...nc3-cosmos-script-runner-api/config/application.rb
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt merged commit ab1f767 into main Dec 25, 2022
@ryanmelt ryanmelt deleted the ace branch December 25, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants