-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework hextof tutorial notebook #274
Conversation
Pull Request Test Coverage Report for Build 8266175784Details
💛 - Coveralls |
It would make sense to solve the data download questions here as well, but if time is an issue, we can also postpone this. |
Upgrading this for use in Maxwell is now more urgent than the data problem. I'd like to merge this as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the basic instructive rewrite, so general aproval. Some things, however, do not work for me, or could be improved, see comments.
Another thing to add would be the histogram normalization, maybe. |
Absolutely! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thoroughly explained. I don't think a new user would have any issues getting into this workflow.
restructure config settings
add parquet folders to gitignore
Deployment stopped because only main branch is allowed to deploy but I overrid it for checking. I think this is good to merge. |
Yes, it's clear that the deploy did not work. I downloaded the generated artefact and checked locally that it was fine. |
added |
74554e2
to
4f72234
Compare
Added explaination of all steps, and full workflow currently available for HEXTOF@FLASH.
This is a simple PR, which changes nothing in fucntionality. I'd love to merge this quickly.
Closes #251