Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] set x_opencti_workflow_id upsert attribute (#7114) #7408

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Jun 18, 2024

Proposed changes

  • set x_opencti_workflow_id upsert attribute to true
  • add ABSTRACT_STIX_RELATIONSHIP in attributePathMapping for x_opencti_workflow_id
  • add missing x_opencti_workflow_id in some addInput : Narrative Sighting DataComponent ``DataSource

associatedclient python PR:
OpenCTI-Platform/client-python#688

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact self-assigned this Jun 18, 2024
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
@marieflorescontact marieflorescontact added the multi-repository For contribution that requires PR in several repository label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (94f5f96) to head (ec081f5).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7408      +/-   ##
==========================================
+ Coverage   67.44%   67.45%   +0.01%     
==========================================
  Files         561      561              
  Lines       69258    69259       +1     
  Branches     5868     5869       +1     
==========================================
+ Hits        46711    46719       +8     
+ Misses      22547    22540       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Goumies
Copy link
Member

Goumies commented Jun 25, 2024

Successfully tested locally with those entities:

  • Malware
  • Malware analyses
  • Note
  • Grouping
  • Report
    And more to come.

@marieflorescontact marieflorescontact merged commit f0c9381 into master Jun 27, 2024
5 checks passed
@marieflorescontact marieflorescontact deleted the issue/7114 branch June 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playbook] Manipulating knowledge by replacing status does not work on all entities.
3 participants