Display the Institutional vetting type hint #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
changed the base branch from
develop
to
feature/sat-link-preferred-activation-flow
MKodde
force-pushed
the
feature/sat-vetting-type-hint
branch
2 times, most recently
from
01a3fd0
to
612f686
Compare
The vetting type of the current language is displayed when it is avaialble.
Identities with a vetted RA desk token where still allowed to create RT's. And that should not be the case. The improved check, created on the AuthzService was not yet rolled out to the controller action or was probably overwritten during a merge conflict.
Focus is only on the vetting type hints in this case
MKodde
force-pushed
the
feature/sat-vetting-type-hint
branch
from
612f686
to
f169560
Compare
pablothedude
approved these changes
Jul 29, 2022
Base automatically changed from
feature/sat-link-preferred-activation-flow
to
feature/self-asserted-tokens
August 1, 2022 07:14
tvdijen
reviewed
Aug 2, 2022
| <source>middleware_client.dto.vetted_second_factor.veting_type.must_be_string</source> | ||
| <target state="new">middleware_client.dto.vetted_second_factor.veting_type.must_be_string</target> | ||
| </trans-unit> | ||
| <trans-unit id="79ec021e919bdadfc0ab50569cfbb52676ce1502" resname="middleware_client.dto.vetted_second_factor.vetting_typ.must_not_be_blank"> |
There was a problem hiding this comment.
vetting_typ? Is this missing an e?
There was a problem hiding this comment.
Also multiple veting on the lines above... missing a t ?
There was a problem hiding this comment.
Typo's are also seen in the en_GB file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If available, show the translated vetting type hint for the institution of the identity logged in to the self service.
The message is displayed on the choose vetting type page (if available). If only one vetting type is present. For example, when only desk vetting is possible. The text is not displayed.
f8f3dd1 was added during acceptance testing of the new feature. It stood out that a user with a token vetted on premise, still was allowed to add recovery tokens. And that should not be the case!
/boyscout