Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate pyuavcan.dsdl generation core to lang/py #234

Closed
wants to merge 11 commits into from
Closed

migrate pyuavcan.dsdl generation core to lang/py #234

wants to merge 11 commits into from

Conversation

coderkalyan
Copy link

I patched the nunavut core to support (recursive) directories in the support directory, but then ended up consolidating all the python support code into a single file nunavut_support.py. Leaving this here in case it comes in handy in the future, it doesn't add any notable complexity. LMK if it should be removed.

Pyuavcan PR coming up in a minute.

@coderkalyan coderkalyan marked this pull request as draft January 27, 2022 05:21
@coderkalyan coderkalyan marked this pull request as ready for review January 27, 2022 05:22
@coderkalyan
Copy link
Author

Actually, I need to check a couple things. Feel free to review though.

@coderkalyan coderkalyan marked this pull request as draft January 27, 2022 05:24
@thirtytwobits
Copy link
Member

This is great. I'll review this tomorrow

pavel-kirienko
pavel-kirienko requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were there any changes to the Jinja templates?

The most interesting thing I suppose is the test suite. Are you planning to integrate it with the same changeset or should we expect a new one later?

src/nunavut/_utilities.py Outdated Show resolved Hide resolved
src/nunavut/jinja/__init__.py Show resolved Hide resolved
src/nunavut/lang/py/__init__.py Show resolved Hide resolved
@thirtytwobits
Copy link
Member

Please run tox -e lint locally and correct all formatting and mypy errors.

@thirtytwobits
Copy link
Member

You need to add numpy to setup.cfg as an install_requires

@coderkalyan
Copy link
Author

Please run tox -e lint locally and correct all formatting and mypy errors.

Already done, will push after fixing a couple mypy issues.

@thirtytwobits
Copy link
Member

This PR is stale. Resubmit to continue with the review. Thanks.

@pavel-kirienko pavel-kirienko mentioned this pull request May 21, 2023
Merged
3 tasks
pavel-kirienko added a commit that referenced this pull request Aug 18, 2023
@pavel-kirienko
Add Python codegen (#306)
b2a82de 
This changeset also drops support for Python 3.6.

Fixes OpenCyphal/pycyphal#110
Required for OpenCyphal/pycyphal#277
Supersedes #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits thirtytwobits left review comments

@pavel-kirienko pavel-kirienko pavel-kirienko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderkalyan @thirtytwobits @pavel-kirienko