Resolving R CMD check NOTE #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tested this with R 4.3.0 where the backported allocLang() kicks in. |
|
Thanks so much Mikko! I’ll look at this tomorrow.
From: Mikko Korpela ***@***.***>
Date: Friday, July 12, 2024 at 1:39 PM
To: OpenDendro/dplR ***@***.***>
Cc: Andy Bunn ***@***.***>, Review requested ***@***.***>
Subject: Re: [OpenDendro/dplR] Resolving R CMD check NOTE (PR #23)
I also tested this with R 4.3.0 where the backported allocLang() kicks in.
—
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7UCXJOILTDWOFYGLXMFL3ZMA5IFAVCNFSM6AAAAABKZQQFV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWGMZDCNRZGQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent R-devel complained about dplR using a non-API entry point. This patch resolves the NOTE. The solution, including a backport for R older than 4.4.1, was adopted from the Writing R Extensions document.
In an unrelated change, a check for R older than 3.0.0 was removed.