prep for initial webodm integration #12
Conversation
merge 1.5.0 api changes from NodeODM
| @@ -1,7 +1,7 @@ | |||
| FROM ubuntu:18.04 | |||
| MAINTAINER Jon-Pierre Stoermer <jp@dronemapper.com> | |||
|
|
|||
| EXPOSE 3000 | |||
There was a problem hiding this comment.
You could also simply remap the port with docker/docker-compose (e.g. docker [..] -p 3001:3000) if you are worried about conflicting ports and two nodes running on the same host!
There was a problem hiding this comment.
I figured as much, just thought it might be cleaner to let NodeMICMAC live on 3001 .. I'm open to whatever works best
There was a problem hiding this comment.
Up to you! As a user I would expect things to be on the same port and then use docker to remap it if needed, but if you think it works better by using port 3001, that's ok too.
There was a problem hiding this comment.
Fair point. I'll do a bit more testing on the WebODM side and see how it works .. starting that integration is why I changed it. dronemapper-io/WebODM@6384f89
No description provided.