Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] DTM/DSM Resolution #914

Closed
smathermather opened this issue Nov 21, 2018 · 3 comments
Closed

[Feature Request] DTM/DSM Resolution #914

smathermather opened this issue Nov 21, 2018 · 3 comments

Comments

@smathermather
Copy link
Contributor

It would be nice to have DSM/DTM resolution based on some multiple of the resolution calculated for the orthophoto, e.g. if ODM calculates that the optimum resolution for orthophoto is 5 cm, default to 20 cm for the DSM and DTM resolutions. This is commonly how closed source packages handle this, and of course, like orthophoto resolution would require a flag for override.

@pierotofy
Copy link
Member

This would be a nice feature. Currently --dem-resolution is the same as --orthophoto-resolution by default (and both are capped by the GSD estimate ceiling, unless --ignore-gsd is used). So you're suggesting that --dem-resolution should be a multiple of --orthophoto-resolution? Or perhaps it's the interpolation radius that should be incremented?

See https://github.com/OpenDroneMap/ODM/blob/master/scripts/odm_dem.py#L96 since we currently don't allow a user to specify the radius.

@smathermather
Copy link
Contributor Author

More the GSD ceiling, and it looks like the interpolation radius gets modified automatically as the GSD changes, though the radius might be useful to expose, I'm not jumping to add more flags for people... .

I put in a pull request for doing 4x this. I'll do some further testing -- I've got someteen thousand images to test this on in the next couple of months, but this patch should help others while we discover what these values should be. I think point clouds need some improvements before we can really understand how to really improve these, but at least we can prevent people from having memory problems.

@smathermather
Copy link
Contributor Author

Closed by #915

peddyhh pushed a commit to peddyhh/ODM that referenced this issue Jun 7, 2020
Proposed solution for OpenDroneMap#914

Former-commit-id: e720d9a
pierotofy pushed a commit that referenced this issue Sep 21, 2020
Proposed solution for #914

Former-commit-id: e720d9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants