Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add blank=True to plugindatum's user field #1523

Merged

Conversation

samul-1
Copy link
Contributor

@samul-1 samul-1 commented Jul 9, 2024

In order to allow for global, plugin-wide settings, the PluginDatum's user field is nullable. However, the field doesn't come with the blank=True keyword argument. This makes it impossible to modify a global plugin setting from the admin panel, because the form will require the corresponding form field to contain a value.

This PR fixes this by adding blank=True to the user field, enabling administrators to change PluginDatum objects keeping the user value to null.

@pierotofy
Copy link
Member

Looks great, thanks @samul-1 !

@pierotofy pierotofy merged commit a0e1acd into OpenDroneMap:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants