Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the OpenDyslexic extension readme #61

Merged
merged 7 commits into from
Mar 13, 2023
Merged

Fixes the OpenDyslexic extension readme #61

merged 7 commits into from
Mar 13, 2023

Conversation

olitreadwell
Copy link
Contributor

About

Came across this readme today and wanted to help with a few fixes

Impacted Areas in Application

The application should not be impacted.

Only changes occurred within the README.

  • Fixed the Chrome extension link
  • Fixed the Firefox add on link
  • Fixed the anchor tag href URL to go to the new .org website
  • Fixed the path for the logo

@olitreadwell
Copy link
Contributor Author

@antijingoist @RobertJGabriel

Made a few small fixes here.

A couple of questions (not addressed in this pull request):

  1. I couldn't find a Microsoft Edge extension, should it be removed?
  2. Would it be better to use <a> anchor tags for the links to allow them to open in a new tab?
  3. Some folks use the GitHub in Dark mode all the time, so the OpenDyslexic logo is black font color on a dark background. Perhaps it would be better to use a non-transparent logo?

@RobertJGabriel
Copy link
Member

Hey @olitreadwell

Looks great, thank you for the pull request.

Will get an OpenDyslexic on the Edge store this weekend.

@RobertJGabriel RobertJGabriel merged commit 6c3aec9 into OpenDyslexic:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants