Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with xf86-input-libinput when specified #4324

Merged
merged 2 commits into from
Sep 16, 2015
Merged

Allow building with xf86-input-libinput when specified #4324

merged 2 commits into from
Sep 16, 2015

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Sep 16, 2015

I'd like to still use libinput for testing on my builds (others may too) so adding LIBINPUT="yes" to you local options file will build xf86-input-libinput instead of xf86-input-evdev.

Also bumping libinput to version 1.0.1

sraue added a commit that referenced this pull request Sep 16, 2015
Allow building with xf86-input-libinput when specified
@sraue sraue merged commit 475db26 into OpenELEC:master Sep 16, 2015
@stefansaraev
Copy link
Contributor

this is wrong. now xf86-input-libinput is always installed.

@stefansaraev
Copy link
Contributor

and we probably have the good old remote bug again.

fyi 'if [ -n $boo ]' is NOT same as 'if [ -n "$boo" ]'

@stefansaraev
Copy link
Contributor

also, when you (again) switch to libinput, please, doubleecheck that keyboard layouts (and switching work. thanks.

@MilhouseVH
Copy link
Contributor

Switching between libinput and evdev requires a clean build - you're right that with this PR we're now building libinput by default, sigh (hadn't noticed any remote issues as I'm yet to do a clean build since this merged).

@stefansaraev
Copy link
Contributor

my suggestion is to completely remove packages/wayland but well. nothing more to say.

you wont see any remote issues on non-x86(xorg)

@MilhouseVH
Copy link
Contributor

you wont see any remote issues on non-x86(xorg)

I know, I build x86 too - currently watching on a Revo 3700 with my own #917 build that includes this PR and no remote issues. Suspect if I build clean then I will have issues.

sraue added a commit that referenced this pull request Sep 20, 2015
Fix error in #4324 that always meant libinput is built
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants