Refactor Channel-Source and Target information #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use actual Channel object for storage, to avoid problems with static enums - Separate Read-Source and Write-Target
sfeilmeier
changed the title
sfeilmeier
added a commit
that referenced
this pull request
Aug 23, 2021
The Channel Source and Target information introduced in #1595 was not working, because Read-Write-Channel information would always be considered a 'target' information. This Pull-Request refactors the information to a generic MetaInfo and allows explicit definition of different read- and write-registers for one Channel
clehne
pushed a commit
to clehne/openems
that referenced
this pull request
Sep 12, 2021
* Refactor ChannelSource - Use actual Channel object for storage, to avoid problems with static enums - Separate Read-Source and Write-Target * Soltaro Cluster C: fix duplicated source * Add Battery-Protection as source for Battery ChargeMaxCurrent/DischargeMaxCurrent * Improve error message for duplicated source/target * Weidmüller Meter: fix register mapping
clehne
pushed a commit
to clehne/openems
that referenced
this pull request
Sep 12, 2021
The Channel Source and Target information introduced in OpenEMS#1595 was not working, because Read-Write-Channel information would always be considered a 'target' information. This Pull-Request refactors the information to a generic MetaInfo and allows explicit definition of different read- and write-registers for one Channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Soltaro Cluster C Channel-Source error and improves general logic