Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional config parameter to specify an optional MQTT topic prefix #2553

Conversation

samuelBloch
Copy link
Contributor

We need an prefix to the default MQTT topic, so an optional config parameter has been added to achive this. If the optional prefix is set, OpenEMS Edge data is published to the MQTT broker under this topic: <optional_prefix>/edge/<edge_id>/...

Copy link

Code Coverage

@Sn0w3y
Copy link
Contributor

Sn0w3y commented Feb 23, 2024

Maybe we should wait until the errors of reconnecting are resolved ?

see here

- rename new setting to `topicPrefix` with default value
- refactor to unit-testable `createTopicPrefix` method
- add JUnit test
Copy link
Contributor

@sfeilmeier sfeilmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it's ok, that I silently updated the PR:

  • rename new setting to topicPrefix with default value
  • refactor to unit-testable createTopicPrefix method
  • add JUnit test

Copy link

Code Coverage

@sfeilmeier sfeilmeier merged commit d3c6a83 into OpenEMS:develop Mar 31, 2024
2 checks passed
@sfeilmeier sfeilmeier deleted the feature/IOT-161-optional-topic-prefix branch March 31, 2024 20:53
Sn0w3y added a commit to Sn0w3y/openems that referenced this pull request Apr 8, 2024
* UI: fix & update translations (OpenEMS#2595)

* Fix Emergency-Slider Translation
* Fix EMERGENCY_RESERVE Case Match

* Gitpod: add names+descriptions to ports (OpenEMS#2600)

* UI: add eslint:recommended and plugin:@typescript-eslint/recommended (OpenEMS#2577)

* add "eslint:recommended", "plugin:@typescript-eslint/recommended" to eslintrc
* `eslint --fix src/`

* Push version to 2024.4.0

* Start development of version 2024.5.0-SNAPSHOT

* MQTT API Controller: add optional config parameter to specify a topic prefix (OpenEMS#2553)

Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de>

* Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf (OpenEMS#2606)

* Bump com.squareup.retrofit2:converter-gson from 2.10.0 to 2.11.0 in /cnf

Bumps [com.squareup.retrofit2:converter-gson](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:converter-gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump com.squareup.retrofit2:adapter-rxjava3 in /cnf

Bumps [com.squareup.retrofit2:adapter-rxjava3](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:adapter-rxjava3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump com.squareup.retrofit2:converter-scalars in /cnf

Bumps [com.squareup.retrofit2:converter-scalars](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:converter-scalars
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf

Bumps [com.squareup.retrofit2:retrofit](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:retrofit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update bnd

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de>

* UI: Fix CSS in footer (OpenEMS#2594)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de>
Co-authored-by: Hiromasa Ihara <iharahiromasa@gmail.com>
Co-authored-by: samuelBloch <125453026+samuelBloch@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
… prefix (OpenEMS#2553)

Co-authored-by: Stefan Feilmeier <stefan.feilmeier@fenecon.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants