Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading metadata via the Website is not consistent #1549

Closed
1 task done
jh-RLI opened this issue Jan 26, 2024 · 1 comment · Fixed by #1550
Closed
1 task done

Downloading metadata via the Website is not consistent #1549

jh-RLI opened this issue Jan 26, 2024 · 1 comment · Fixed by #1550
Assignees
Labels
bug metadata oemetaBuilder Feature of the OEP-Website: Create and edit oemetadata

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented Jan 26, 2024

Description of the issue

Currently we offer two download buttons:

  1. Via the table-detail pages in the meta information tab:
    image

  2. As part of the oemetaBuilder tool for creating/edeting oemetadata:
    image

The resulting json file is not consistent:

  • Empty fields are either empty strings or null
  • The metadata contains different fields, for example in the context field of the oemeta data

The problem occurs because:

  • The oemetaBuilder only uses the json schema provided for an oemetadata release.
  • The "Download json" button on the table´s "meta information" tab retrieves the metadata from the database in which the metadata was compiled using omi before it was saved.

Steps to Reproduce

tbd

Ideas of solution

In general, make sure that the metadata is always the same and complies with the oemetada specification for the version to which the metadata refers.

This could include an omi update or the inclusion of omi in the download function of the metaBuilder tool.

First, determine if omi is returning correct results.

Context and Environment

  • Version used:
  • Operating system:
  • Environment setup and (python) version:

Workflow checklist

@jh-RLI jh-RLI added the bug label Jan 26, 2024
@jh-RLI jh-RLI self-assigned this Jan 26, 2024
@jh-RLI jh-RLI added metadata oemetaBuilder Feature of the OEP-Website: Create and edit oemetadata labels Jan 26, 2024
@jh-RLI
Copy link
Contributor Author

jh-RLI commented Jan 26, 2024

There was a thing (I would call it a bug) in omi that intentionally removes these fields from context if they are null:

"fundingAgency": null,
"fundingAgencyLogo": null,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug metadata oemetaBuilder Feature of the OEP-Website: Create and edit oemetadata
Projects
Development

Successfully merging a pull request may close this issue.

1 participant