Features/refactoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement internal structure to hold OEP metadata * Implement compiler to translate internal structure to OEP Metadata v1.4
Python3.5 does not support it and we do not really use it
Some license ids end with `+` this leads to errors in license handling
A renderer takes a structure used in a dialect (e.g. JSON, RDF) and translates it into a string
fields did not have a resource in foreign keys
The translation to rdf loses the ordering information for all lists in the metadata. See #5 for more information
* introduce load method to load string into input structure (e.g. JSON, RDF-graph) * parse() expects those structures * parse_from_string covers the former string functionality
Closed
|
Closes #1 |
|
Closes #2 |
christian-rli
approved these changes
Jun 13, 2019
|
|
||
|
|
||
| def main(): | ||
| cli() |
There was a problem hiding this comment.
I'd just like to state and thereby express my appreciation of how clean this looks.
| "BSL-1.0": "https://spdx.org/licenses/BSL-1.0.html", | ||
| "Bahyph": "https://spdx.org/licenses/Bahyph.html", | ||
| "Barr": "https://spdx.org/licenses/Barr.html", | ||
| "Beerware": "https://spdx.org/licenses/Beerware.html", |
There was a problem hiding this comment.
I'm really glad to find this included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a python-based internal structure for OEP metadata and four major concepts