-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back: first services #12
Conversation
This is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this review! This currently looks good to me; I added a comment concerning the sigmon object, and you answered my other question concerning the AddVoucher method. I like the idea of separating the user and auth services and having this voucher method of messaging between them.
} | ||
|
||
func run() error { | ||
sm := sigmon.New(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does sigmon do in this context? Will this be the web server we use?
sigmon is a simple way to handle system signals. It allows us to type {Ctrl-C} to send SIGTERM to the application and have the application take some action. The This application is a demonstration of a running GRPC server. It's only purpose for now is as an example of how to add services to the GRPC server. Each commit in this branch takes a small step toward adding one of two services and then wiring them together. In order to get the "free HTTP" mentioned, we will leverage GRPC-Gateway. An instance of a gateway is created, with the relevant services registered to it. This is then served on it's own separate port. In effect, the GRPC is then a backend to the HTTP backend. If needed later on, we can add a GraphQL termination point. Though, this would likely mean adding another set of messages which are more highly related/intermingled. Similarly, if HTTP2 is not sufficient for our use case at mitigating transport costs, but GraphQL remains not worth setting up, specific "view messages" could be added as needed. Depending on the circumstances at the time, either of these two systems can be added as a standalone server on it's own port using the GRPC server as a backend, added to some subset of paths (routes) in the then existing HTTP server, or as a standalone server using the HTTP server as a backend. The last option might be dumb, and it might help take care of the whole GraphQL caching issue. I'm not sure; It's late. |
@champagneabuelo I just added a frontend file server. To try it out, run The front files are currently being served using a relative path, but I'll work out how to run the project from anywhere. It will likely require the usage of some flag or envvar (preferably a flag). A good test file is http://localhost:4244/css/main.css |
I'll merge this once I get an OK on the temporary front server. |
Working on getting in running locally now! Will report back soon. |
After running the |
That is a random generated type that I selected to print just to prove that the generated code was working. Did it also give a notice about gracefully stopping the application? |
Fixes #8