Bounds Check Bug in WAMIT2 Submodule of HydroDyn

[jjonkman]

The upper bound on WaveDir is checked incorrectly in the WAMIT2 submodule of HydroDyn. See the following forum topic for details: https://wind.nrel.gov/forum/wind/viewtopic.php?f=4&t=1670.

The second problem reported in that forum topic is not a bug; the direction pairs must be fully populated (not sparse).

[karchramboll]

I have problems with calculating 2nd order wave forces on the basis of WAMIT output files .8 or .9. I tried the possible options (MnDrift=8 or 9, or NewmanApp=8 or 9) bot an error is caused by WAMIT2.f90 stating "Maximum wave direction required of [...] is found in the WAMIT data file...

Is there a working example available including WAMIT files, so I can check the input format? I am using WAMIT v6.4. The mean drift forces in files 8 and 9 are calculated using IOPTN(8)=2 and IOPTN(9)=2.

[jjonkman]

Unfortunately, the bug reported in the forum topic listed above has not yet been fixed by a pull request. And I don't have a HydroDyn example where the mean-drift loads are calculated from WAMIT *.8 or *.9 output files. While I thought these features were tested before they were released in HydroDyn, I don't have them in my records and those who did the implementation are no longer at NREL. Perhaps another OpenFAST user/developer can comment.

Have you tried to implement the code change suggested in the forum topic listed above; if so, did that help?

[andrew-platt]

After reviewing the forum posting and checking the code, I can confirm this is a bug. This has been fixed in commit b736f5b in the TCF development work, and will be merged into the dev branch with that code.