-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced order models: AeroDisk and Simplified-ElastoDyn (SED) #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to remove an override of the position for the Nacelle mesh in PR OpenFAST#982.
The cause was an index that never got set. So this could result in attempting to retrieve a value from the output mapping array using an out of bounds index (sometimes a very large negative number). This never appeared in gcc compiled versions, but occasionally would appear in certain intel compiled versions (others initialized the value apparently).
It all compiles, but does nothing
It all compiles, but does nothing
… not default value
- Also add a bit to the driver
- also added a generic table writer that will write to whatever unit specified
This goes with commit 61e4326, but got missed somehow
andrew-platt
force-pushed
the
f/ReducedOrdModel
branch
from
August 12, 2024 19:40
29ad020
to
638e084
Compare
15 tasks
Merged
deslaughter
reviewed
Aug 19, 2024
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Change dates on copywrites, and remove unused code blocks from reg-testing Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
Co-authored-by: Derek Slaughter <deslaughter@gmail.com>
deslaughter
approved these changes
Aug 20, 2024
Updated a few var names in the AD input fles changed label in CTest from `aerodyn15` to `aerodyn`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FAST.Farm
Module: AeroDisk
Disk actuator aerodynamics model
Module: OpenFAST Lib
Module: SED
Simplified-ElastoDyn
Type: Enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Feature or improvement description
Two new modules are added for low fidelity modeling of aerodynamics and structure. These modules are intended for use as very low fidelity turbines in a FAST.Farm simulation in order to speed up the overall simulation. In such a use case, these might be placed in the front few rows of a FAST.Farm simulation where only the turbines in rows further back are of interest, but the wake effects from the leading turbines are needed.
Impacted areas of the software
Additional supporting information
Test results, if applicable
Three new OpenFAST test cases are added as modifications of the
5MW_Land_DLL_WTurb
case:5MW_Land_DLL_WTurb_SED
-- SED instead of ED5MW_Land_DLL_WTurb_ADsk
-- AeroDisk module instead of AD155MW_Land_DLL_WTurb_ADsk_SED
-- AeroDisk instead of AD15, and SED instead of EDNew module tests are also included for SED and ADsk.
To complete
Phase shift in GenPwr for5MW_Land_DLL_WTurb_ADsk_SED
case (possibly mesh issue in glue code?)This was an input file issue
SED + AD15 can result in tower strike event (possible mesh issue, or maybe setup -- not investigated yet)This was a setup issue
5MW_Land_DLL_WTurb
case (AD15 + ED with controller)