Release 3.5.1 #1820
Release 3.5.1 #1820
Conversation
Update WAMIT .hst input file and baselines for floating MHK r-test
Update HydroDyn input file and baselines for floating MHK r-test
The input arrays for Lidar to ServoDyn get allocated in ServoDyn.f90, and again in BladedInterface_EX.f90. This double allocation causes issues for many compilers. The logic behind all this really should be looked at in more detail, but since the Lidar module in InflowWind will be superceeded by LidarSim in release 4.0.0, I'm not going to sort the logic right now.
Affected arrays:
u%LidSpeed
u%MsrPositionsX
u%MsrPositionsY
u%MsrPositionsZ
Thanks to @foxton9 for reporting the issue, and proposing the fix!
This was reported in issue #1484
[BugFix] ServoDyn inputs for Lidar allocated twice, and a few other minor issues
[BugFix] HD wave visualization with 2nd order waves
The last revision had the incorrect case for the CMake variable, so the flag wasn't being added
We added the hub point to AWAE at the center of the grid now that IfW calculates the disk average velocity every time IfW_CalcOutput gets called. But this point needs to be shifted by the turbine position so it is in the box. This will all change in 4.0.0 when we switch to pointers for all this and don't call IfW_CalcOutput directly anymore.
Fix adding OpenMP flags to CMAKE_Fortran_FLAGS
FF: fix bug with Mod_AmbWind=3 -- hub point wasn't shifted.
This is a hack fix -- the logic really should be improved elsewhere in the code for checking if any blades are output. However, we don't actually have logic in place yet for only outputting certain blades.
This was causing issues in the linearization as the reported windspeed was on the order of 1E+38, which did not format correctly in the `.lin` output file
ED/AD: fix segfault when BldNd_BladesOut==0
[BuFix] InflowWind was not setting InitOut MWS data.
AD: Adding rtest for TailFin polar-based model
andrew-platt
added
Type: Build issue
FAST.Farm
Module: NWTC Lib
Feature: MHK
|
@RyanDavies19, @hkross, @luwang00, @bjonkman -- if you have time, could your review changes from PR's of yours that are included in this release? |
|
Live documentation for this PR: https://openfast.readthedocs.io/en/rc-3.5.1/ |
|
@andrew-platt All looks good on the MoorDyn side aside from three erroneous print statements left behind from debugging. I just created a PR to this release that removes them. |
|
@RyanDavies19, good catch! Thanks for fixing that. |
|
Note: the OC3Trpd case fails sporadically. There is likely an uninitialized variable or two that is causing this. Since a significant amount of the code that could contribute to this is getting revised in 4.0, so we won't fix it here. |
There was a problem hiding this comment.
Nice to see this version finally released; thanks!
Please note that in the first Conversation field, under "Input file changes", the link the r-test is currently https://github.com/OpenFAST/r-test/tree/rc-3.5.1 rather than https://github.com/OpenFAST/r-test/tree/v3.5.1 (I assume this will be fixed when the updated r-test is released as well.)
@andrew-platt Looks good to me! |
|
@andrew-platt For HD, there is also the recent PR #1806 which fixed some existing bugs with the strip-theory loads and updated the radiation convolution integral to 2nd order. Should we point that out in this PR as well? |
Feature or improvement description
Pull request to merge
rc-3.5.1intomainand create a tagged release for v3.5.1.See the milestone and project pages for additional information
Test results, if applicable
See GitHub Actions
Release checklist:
Changelog
General
Build systems
#1586 CMake: Remove openfast_cpp target if BUILD_OPENFAST_CPP_API not selected
#1647 Fix adding OpenMP flags to CMAKE_Fortran_FLAGS
#1818 VS-build updates for rc-3.5.1 and other minor updates. Includes truing up some Types files.
Documentation
#1788 Readthedocs configuration changes
Solvers
FAST.Farm
#1648 Fix bug with Mod_AmbWind=3 -- hub point wasn't shifted.
Module changes
AeroDyn
#1657 AD Driver: stack size for 64 bit solutions (see #1260)
#1658 AD/TailFin: Bug Fix: remove chord in fy (see #1653)
#1659 AD: Adding rtest for TailFin polar-based model
#1679 AD: nodal outputs in different coordinate systems (new feature)
#1700 Remove deleted variables BlFB and BlMB from AeroDyn_AllBldNdOuts_IO
BeamDyn
#1771 Change BD states to follow the blade root reference frame. Small performance improvements around azimuth=180.
#1796 Resolve BeamDyn initial strain for rotated blade. Backport of #1663
ElastoDyn
#1654 fix segfault when BldNd_BladesOut==0 (Also for AeroDyn)
HydroDyn
#1621 [BugFix] HD wave visualization with 2nd order waves
#1780 [BugFix] AddF0 for multiple potential-flow bodies with NBodyMod/=0 (backport of #1776)
#1768 new feature: Visualization of HydroDyn Morison mesh (also MoorDyn lines)
#1806 fixed some existing bugs with the strip-theory loads and updated the radiation convolution integral to 2nd order
InflowWind
#1620 [BugFix] ServoDyn inputs for Lidar allocated twice, and a few other minor issues
#1655 [BugFix] InflowWind was not setting InitOut MWS data.
#1748 [BugFix] compute vel avg profile when exceed allowed
#1759 [BugFix] InflowWind Flow Field fails to calculate AvgVel for large wind files when using Intel Compiler
#1769 [BugFix] Add additional modulo in IfW_FlowField to correct error with exhausted field from Grid3D on long simulations (see #1746 and PR #1730)
MAP++
#1752 MAP++ linear spring approach improvement (@RBergua)
MoorDyn
#1768 MoorDyn line visualization (see HydroDyn above)
#1727 MoorDyn updates and bug fixes (naming, catenary solve improvement, output channels, bugs with added mass, rods, and comment typos
#1815 MoorDyn dynamic relaxation and fixed bodies
#1816 Fixed drag coefficient scaling
NWTC-Library
#1731 Blade Pitch input to ElastoDyn drifts during solution if ServoDyn is not active (improvements to Extrap/Interp routines)
SubDyn
#1802 Increase SubDyn output to allow NMOutputs up to 99. Backport of features from dev (multiple commits)
Regression tests
#1581, #1593 Update floating MHK case input files
#1694 Improved linearization file comparison
#1695 AD: adding linearization tests for aerodyn continuous-states model
#1801 Add Mod_AmbWind=3 regression test to the CI
Input file changes
No input files change with this release, as this only includes minor bugfixes.
Full list of changes: https://openfast.readthedocs.io/en/main/source/user/api_change.html
Full input file sets: https://github.com/OpenFAST/r-test/tree/v3.5.1 (example input files from the regression testing)