SD: Remove the misleading CBMod input #2401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull request slightly modifies the SubDyn input file by removing the
CBMod
T/F switch. This input can be misleading because irrespective ofCBMod
, SubDyn always transforms the equations of motion to be in terms of Guyan and Craig-Bampton modes. SettingCBMod
to false simply lets SubDyn retain all Craig-Bampton modes.To better reflect how SubDyn actually functions, the
CBMod
switch is removed. Instead, ifNmodes
>=0, SubDyn will function as ifCBMod
is true in previous versions. Alternatively, settingNmodes
<0 will let SubDyn retain all Craig-Bampton modes, recovering the same behavior withCBMod
set to false in previous versions.The user documentation for SubDyn is updated to reflect the removal of
CBMod
from the primary input file. The removal ofGuyanLoadCorrection
from the input file is also briefly explained (see PR #2203).Impacted areas of the software
SubDyn, Docs
Test results, if applicable
There is no change to existing test results. All r-test SubDyn input files are updated by removing
CBMod
.