Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElastoDyn blade-node rotational velocity and translational acceleration output #391

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

bjonkman
Copy link
Contributor

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE

Feature or improvement description
Added rotational velocity and translational acceleration to ElastoDyn blade-node output mesh (with help from @jjonkman)

Related issue, if one exists
Fixes #39

Impacted areas of the software
This could have a small effect on models that use AeroDyn15 and ElastoDyn where the two models have nodes that are some distance apart.

@jjonkman jjonkman self-requested a review February 12, 2020 21:45
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked with Bonnie on this change and approve this pull request.

@andrew-platt
Copy link
Collaborator

Is there an OutListParameters.xlsx for ElastoDyn somewhere?

@jjonkman
Copy link
Collaborator

As far as I understand, the OutListParameters.xlsx spreadsheet included in the FAST v8.16 archive is the most up-to-date version, but has not yet been migrated to the OpenFAST GitHub repo. This spreadsheet contains tabs for both ElastoDyn and ServoDyn (and copies of the OutList for BeamDyn and AeroDyn v15).

@andrew-platt
Copy link
Collaborator

We've split migrated several to GitHub at this point and updated them to reflect recent changes (AeroDyn, AeroDyn14, BeamDyn, InflowWind, OrcaFlex Interface). I think the rest are still in the openfast-library/src/ copy. Could you update that one with the new ElastoDyn channels?

@bjonkman
Copy link
Contributor Author

Please see this sheet for updated channels: https://github.com/bjonkman/openfast/blob/f/Linear/modules/openfast-library/src/OutListParameters.xlsx. I really want only one version of this spreadsheet with separate tabs for each module. It's super painful to have multiple spreadsheets with the same name.

HOWEVER, this pull request doesn't add WriteOutput values, it merely adds values to the mesh output so that the motions can be transferred correctly to other modules. No change to the spreadsheet is necessary.

@andrew-platt
Copy link
Collaborator

Perfect. Thanks for the clarification.

@andrew-platt andrew-platt merged commit 6bd2e0a into OpenFAST:dev Feb 28, 2020
@bjonkman bjonkman deleted the b/EDBladeMesh_Issue39 branch March 31, 2020 22:33
@rafmudaf rafmudaf mentioned this pull request Apr 2, 2020
jjonkman added a commit to jjonkman/OpenFAST that referenced this pull request May 29, 2020
jjonkman added a commit to jjonkman/OpenFAST that referenced this pull request May 29, 2020
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Jun 10, 2020
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Jun 10, 2020
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Jun 10, 2020
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Jun 12, 2020
rafmudaf pushed a commit that referenced this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants