minor bug fix #431
Merged
minor bug fix #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we change this to a PR to the |
|
Well actually it looks like @lapadron left off the commit making the change. This pull request only contains the commits already on |
|
@lapadron did you push your update to your branch on GitHub? |
|
Sorry. I hadn't done the 'git add'. Now I did it and repeated steps 5 and 6. Do I need to do a new pull request now? |
rafmudaf
reviewed
Mar 27, 2020
|
|
|
Ah good point @andrew-platt |
…ion of array SDin was being accessed
…re/MinorBugFix Minor bug fix in SubDyn_Driver. The first dimension of array SDin was being accessed from index 0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
Minor bug fix in SubDyn_Driver. The first dimension of array SDin was begin accessed from index 0 and the do loop had one step too many.
Impacted areas of the software
SubDyn_Driver