Fix bug that could cause incorrect loads transfer in Line2-to-Line2 or Line2-to-Point mapping #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line2-to-Line2 or Line2-to-Point load transfers in some instances could have created augmented meshes with nodes in incorrect places, and possibly cause incorrect loads transfer in the process. Also fixed the mesh debugging code so that if a mesh has scalar quantities, it stores the number of scalars that it is writing to the binary file.
|
I've discussed this previously unknown bug and fix with @bjonkman and approve this pull request. |
|
Good catch! I think I've seen this bug once with a BeamDyn test case, but thought it was just something odd with BeamDyn. |
jjonkman
approved these changes
Jul 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This pull request fixes a problem identified in the implementation of the mesh mapping line2-to-line2 and line2-to-point loads-transfer algorithm. The algorithm to create the augmented source mesh would split an element but--in certain (fairly rare?) instances--incorrectly calculate the position of the new node, effectively increasing the load being transferred.
Related issue, if one exists
None
Impacted areas of the software
This may impact any modules that have distributed loads output. This includes any models that use
Additional supporting information
I have attached a plot showing a case where this bug was triggered. The red line shows the smooth loads expected from AeroDyn's output mesh; the blue line indicates how the loads input to the structural code were being calculated prior to this bug fix:
Test results, if applicable
The regression tests look the same (with the exception of the numerical instability in the SWRT case), indicating that this bug probably wasn't triggered in any of these test cases.