InflowWind Updates #578
Merged
InflowWind Updates #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InflowWind driver:
----
- functionality:
- added option to convert file formats
- input file changes:
- added section for file conversion options
- moved dt after timeStart (before summary stuff)
- removed inflowWind setup section header
- skip reading GridCtrCoord, GridD{x|y|z}, and GridN{x|y|z} lines if they aren't going to be used (and don't print them in summary file)
InflowWind:
---
- added code to include vertical flow angle (to rotate FF wind boxes vertically, too)
- added base FF wind module so TurbSim, Bladed, and HAWC2 formats can use common code (all three formats use the same base code for interpolation, mean wind speed, etc)
- added LHR rule for Bladed-generated winds
- option for native Bladed file formats
- return 0 wind speed at and below the ground height (z=0) instead of producing an error
- This allows different wind boxes to be rotated about (0,0,RefHt). - fixed issue with how native-Bladed wind boxes were rotated before - removed unused variables - fixed spelling errors
- do not allow vertical flow angle for linearization (requires re-working of the math, which I haven't had time to do) - added check for weird problem with linux compilers seeming to return results from MODULO function in unexpected range. - files listed in the IfW driver will be relative to the file they are specified in - fixed some error handling - allow the uniform wind files to contain an additional column specifying the upflow angle - added `Wind*VelXY`, `Wind*VelMag`, and `WindAngXY` output channels
Incorrect sizing of the FileIndx array
|
After merging the PR to this branch, the |
merge of dev changes to InflowWind
+ update comments in code
rafmudaf
added
the
Approved: Update baselines
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Dec 17, 2020
andrew-platt
added a commit
to andrew-platt/openfast
that referenced
this pull request
Dec 17, 2020
andrew-platt
added a commit
that referenced
this pull request
Dec 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request IS ready to merge.
Before merging,
Feature or improvement description
InflowWind driver:
InflowWind:
Wind*VelXY,Wind*VelMag, andWindAngXYoutput channelsVFlowAng(upflow angle) in the InflowWind input fileOther:
Related issue, if one exists
None
Impacted areas of the software
InflowWind, Windows Visual Studio build, documentation, cmake
Test results, if applicable
One case fails. All of the channels that depend on turbine dynamics have a sharp increase in the error plots at 25.75 seconds, which then dies out. The differences are still small here, though: max L2 norm is 2.0808e-04, and you really have to zoom in to see differences in the time series. The inflow channels at the hub has 0 error. Here is the channel with the max error: