Use RANLUX pRNG in offshore floating regression test cases #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull request uses the recently-added RANLUX pRNG in HydroDyn to create the initial wave profiles. As notes in #89, using intrinsic pRNG in scientific software causes issues when comparing the results across platforms and compilers. Using a consistent pRNG algorithm resolves this issue.
Related issue, if one exists
#89
Impacted areas of the software
OpenFAST regression test cases which use the irregular wave feature of HydroDyn
Additional supporting information
This brings the various solution sets closer together, but there are still some small differences.
Test results, if applicable
See GitHub Actions.