Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable regression tests for the C++ API #670

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

rafmudaf
Copy link
Collaborator

@rafmudaf rafmudaf commented Feb 26, 2021

Feature or improvement description
This pull request add the testing infrastructure to create regression tests for the C++ API. It adds a single test that runs an existing OpenFAST regression test through the C++ API with the C++ driver code and compares the results to the baselines in the OpenFAST r-test repository.

This pull request also adds consistent formatting to the C++ code. The changes to OpenFAST.cpp are only formatting changes.

Impacted areas of the software
C++ API, C++ driver code, regression test configuration.

Additional supporting information
The included test is a simple test to ensure the C++ API compiles and runs in a basic state. The included infrastructure should be used to generate new tests for expanded testing.

Primarily, the next step is to establish a test for #666.

Copy link
Collaborator

@gantech gantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and a necessary first step to catch all errors here.

@rafmudaf rafmudaf merged commit f2e682e into OpenFAST:dev Mar 1, 2021
@rafmudaf rafmudaf deleted the cpp_api_test branch March 9, 2021 04:55
@sayerhs
Copy link
Contributor

sayerhs commented Apr 7, 2021

@rafmudaf

  • when did OpenFAST move to C++17 standard?
  • OpenFAST C++ driver is still part of the install target right? So even if we only use the library to link to nalu-wind, installation step would still fail. So this is a breaking change.

@rafmudaf rafmudaf mentioned this pull request May 12, 2021
11 tasks
andrew-platt added a commit to andrew-platt/openfast that referenced this pull request Mar 21, 2022
This missing file was causing SOWFA builds on Eagle to fail.

The ExaWind build doesn't need this, but SOWFA does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants