BD Driver bug fix and expand BeamDyn unit testing #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expansion of test_tools required modifications to the indicated test routines. test_BD_QuadraturePointData.F90 tests the following routines: BD_QuadraturePointDataAt0, BD_DisplacementQP BD_RotationalInterpQP BD_StifAtDeformedQP
…twist; all unit tests and regression tests pass
…th non-zero hub radius and non-identity orientation
andrew-platt
reviewed
Mar 5, 2021
rafmudaf
approved these changes
Mar 8, 2021
ashesh2512
approved these changes
Mar 8, 2021
Remove unnecessary comment block
rafmudaf
changed the title
# Conflicts: # reg_tests/r-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test test_BD_QuadraturePointData.F90, which tests multiple components required to calculate quantities at quadrature points; also tests components found in BD_QuadraturePointDataAt0.
Fixed a bug in Driver_Beam.f90
Rewrote logic in BeamDyn_Subs.f90:BD_ComputeIniNodalCrv, which appears to give the same answer but was more intuitive.
All unit tests pass.
BeamDyn regression tests will pass, except for bd_5MW_dynamic_gravity_Az90, which needs GlbRotBladeT0 = True in bd_driver.inp