[BugFix] unallocated AD%y%Rotors when AD14 is used with cpp interface #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FillOutputAry_T routine tried to pass Turbine(iTurb)%AD%y%Rotors(1) to FillOutputAry, but the AD%y%Rotors was not allocated for cases where AD15 was not used. The logic within FillOutputAry and the variables passed into it have been modified accordingly. NOTE: this set of routines is only called from the FAST_Library, so this issue would only appear with the cpp interface when AD14 is used (I only know of one Simulink example case that this would affect)
ebranlard
approved these changes
Apr 2, 2021
bjonkman
reviewed
Apr 12, 2021
rafmudaf
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the cpp interface with AD14, the
FillOutputAry_Troutine tried to passTurbine(iTurb)%AD%y%Rotors(1)toFillOutputAry, but theAD%y%Rotorswas not allocated. This bug was introduced with PR #672.The logic within
FillOutputAryand the variables passed into it have been modified somewhat similarly to how BeamDyn and IceDyn outputs are handled.NOTE: this set of routines is only called from the FAST_Library, so this issue would only appear with the cpp interface when AD14 is used (I only know of one Simulink example case that this would affect)
This PR is ready to merge
The example Simulink case
Run_Test01_SIG.mused AD14 with Simulink. A segmentation fault occurred with this example case (this case is not included in the regression tests).Close #692