Skip to content

Commit e8366d0

Browse files
maly7kdavisk6
authored andcommitted
Allow 1xx status codes (#871)
* add support for 1xx status codes in Response * allow for any status code
1 parent db44bfe commit e8366d0

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

core/src/main/java/feign/Response.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public final class Response implements Closeable {
4545
private final Request request;
4646

4747
private Response(Builder builder) {
48-
checkState(builder.status >= 200, "Invalid status code: %s", builder.status);
4948
checkState(builder.request != null, "original request is required");
5049
this.status = builder.status;
5150
this.request = builder.request;

core/src/test/java/feign/ResponseTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
package feign;
1515

1616
import feign.Request.HttpMethod;
17+
import org.assertj.core.util.Lists;
1718
import org.junit.Test;
1819
import java.util.Arrays;
1920
import java.util.Collection;
@@ -81,4 +82,28 @@ public void headersAreOptional() {
8182
.build();
8283
assertThat(response.headers()).isNotNull().isEmpty();
8384
}
85+
86+
@Test
87+
public void support1xxStatusCodes() {
88+
Response response = Response.builder()
89+
.status(103)
90+
.request(Request.create(HttpMethod.GET, "/api", Collections.emptyMap(), null, Util.UTF_8))
91+
.body((Response.Body) null)
92+
.build();
93+
94+
assertThat(response.status()).isEqualTo(103);
95+
}
96+
97+
@Test
98+
public void statusCodesOfAnyValueAreAllowed() {
99+
Lists.list(600, 50, 35600).forEach(statusCode -> {
100+
Response response = Response.builder()
101+
.status(statusCode)
102+
.request(Request.create(HttpMethod.GET, "/api", Collections.emptyMap(), null, Util.UTF_8))
103+
.body((Response.Body) null)
104+
.build();
105+
106+
assertThat(response.status()).isEqualTo(statusCode);
107+
});
108+
}
84109
}

0 commit comments

Comments
 (0)