Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a release #643

Closed
codefromthecrypt opened this issue Feb 27, 2018 · 18 comments
Closed

Do a release #643

codefromthecrypt opened this issue Feb 27, 2018 · 18 comments

Comments

@codefromthecrypt
Copy link
Contributor

I will help do a release by the end of the week. Ping here PRs you think should make the cut. Ping also here if you want to audit the release!

@velo
Copy link
Member

velo commented Feb 27, 2018

I can try out the release... have a few projects with feign and could easily bump versions to see how it behaves.

@codefromthecrypt
Copy link
Contributor Author

@velo let's get you in shape to do a test release. Forget about features for now until #646

@velo
Copy link
Member

velo commented Mar 5, 2018

ok, so, how are we going to do that?

are you going to stage a build or shall I build one?

@codefromthecrypt
Copy link
Contributor Author

@velo you'd be on point and I'd help you with what you need

@velo
Copy link
Member

velo commented Mar 6, 2018

Ok, add doNotCloseAfterDecode flag to Feign builder was merged #649

Are we waiting on something else or shall I get started?

@velo
Copy link
Member

velo commented Mar 6, 2018

BTW, this is how I usually do a release...
velo/manifest-validator-maven-plugin#2

hopefully will be able to get feign doing something similar for the next release

@foezor
Copy link

foezor commented Mar 6, 2018

@velo maybe this issue #651 it can help to validate benchmark on the version but i'm not sure if everything is ok on it since the build is not passing

@velo
Copy link
Member

velo commented Mar 6, 2018

my impression was that we would just include the closeAfterDecode and leave the StreamDecoder behind

#587 (comment)

@phymbert
Copy link
Contributor

phymbert commented Mar 6, 2018

I have updated #651 with all requested changes identified by @adriancole. I think we may let this feature a chance in 9.6 without waiting so much.

@phymbert
Copy link
Contributor

phymbert commented Mar 6, 2018

in-extenso Is there enough feature in 9.6 on master to start a feature release right now ?

@velo
Copy link
Member

velo commented Mar 6, 2018

Fair point, only includes add doNotCloseAfterDecode

@MrBogue
Copy link

MrBogue commented Mar 8, 2018

Could you please confirm the release of version 9.6.0 by the end of this week?
We are still waiting for it to be available on the Maven Repository,

@velo
Copy link
Member

velo commented Mar 8, 2018

@MrBogue what feature of 9.6.0 are you waiting on?

We are waiting on #651

@MrBogue
Copy link

MrBogue commented Mar 9, 2018

@velo we are waiting on #649

@velo
Copy link
Member

velo commented Mar 9, 2018

Beging release

@velo
Copy link
Member

velo commented Mar 10, 2018

Seems 9.6.0 is now on maven central. What next?

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Mar 10, 2018 via email

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Mar 10, 2018 via email

@velo velo closed this as completed in #627 Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants