Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of Java8 Stream and Jackson Parser #586

Closed
wants to merge 25 commits into from

Conversation

phymbert
Copy link
Contributor

No description provided.

spencergibb and others added 23 commits March 3, 2017 10:04
* Avoid `Decoder.decode` on 404 when void response type

Avoid calling `decode` when receiving a 404 error and `decode404` is set and the response type is `void`.

* Update CHANGELOG
Signed-off-by: Jonathan Fuerth <jonathan@helpful.com>
Adds `Feign.Builder.mapAndDecode()` to allow response preprocessing before decoding it
Introduces `feign-java8` with support for `java.util.Optional`
…OpenFeign#555)

support the query values starting with {, when use RibbonClient。different from OpenFeign#540.
A recent change to the ./mvnw script changed output slightly and broke
the logic which detected versions. This fixes it.
…enFeign#569)

* Add the Content-Type if specified, unless we are setting the body

* Update changelog
Otherwise RequestBuilder will create HttpEntity from query parameters.
@phymbert
Copy link
Contributor Author

This first PR commit allows to stream only the response body in java8 way.
I have also tried to stream request body based on InputStream as suggested by @spencergibb on #220. But it requires additional changes on the core and maybe not appropriate implementation.
You can have a look on this fork.
@adriancole Please tell if it is eligible to another PR or should be included in this one or cancelled.

Fixes #514.

@phymbert phymbert closed this Aug 22, 2017
@phymbert phymbert deleted the JAVA8_STREAM branch August 22, 2017 15:47
@phymbert
Copy link
Contributor Author

phymbert commented Aug 22, 2017

Apologize once again... Messed up with rebase/merging.
Please see new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.