Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log LOMAP errors? #35

Open
dwhswenson opened this issue Apr 15, 2022 · 1 comment
Open

Log LOMAP errors? #35

dwhswenson opened this issue Apr 15, 2022 · 1 comment

Comments

@dwhswenson
Copy link
Member

Currently we hide any errors coming from LOMAP in the atom mapper. This is so that we can feed it ligands that might not be able to be mapped at all, and it acts as a sort of filter.

But this also means that it tedious to debug any issues that pop up in LOMAP, because we just get back no mappings with no feedback as to what went wrong. To get any details, you need to drop out of the OpenFE world and into the raw LOMAP/RDKit.

Maybe we make should the errors we catch into an INFO level log event?

@richardjgowers
Copy link
Contributor

richardjgowers commented Apr 15, 2022 via email

@richardjgowers richardjgowers transferred this issue from OpenFreeEnergy/openfe Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants