Add function to visualization_3D.py - show_ComponentCoords #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding visualize Component Coordinates. give a list of Components get a view with all components overlayed.
adding smoke tests.
IAlibay
requested changes
Feb 17, 2023
IAlibay
previously requested changes
Feb 17, 2023
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
better name func.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
better naming, adding optional shift, typing correction
fixing mypy I
mypy fix II
mypy fix III
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 92.86% 92.89% +0.03%
==========================================
Files 66 66
Lines 4764 4788 +24
==========================================
+ Hits 4424 4448 +24
Misses 340 340
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
richardjgowers
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding visualize Component Coordinates. give a list of Components get a view with all components overlayed.
This helps with checking the 3D coords and understanding geometries.